docs(faq): added ipv6 default fix #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagpreetsinghsasan
requested review from
petermetz,
takeutak,
izuru0,
VRamakrishna,
sandeepnRES and
outSH
as code owners
petermetz
requested changes
Jun 12, 2024
jagpreetsinghsasan
force-pushed
the
feat-faqipv6
branch
from
0f29d70
to
692f3c7
Compare
|
@petermetz I have updated the faq (yes, indeed the logs were must). |
petermetz
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
@jagpreetsinghsasan Thank you very much for the updates! LGTM
outSH
requested changes
Jun 14, 2024
sandeepnRES
approved these changes
Jun 19, 2024
|
@jagpreetsinghsasan Are you still working on this one? |
jagpreetsinghsasan
force-pushed
the
feat-faqipv6
branch
from
692f3c7
to
a3895b0
Compare
jagpreetsinghsasan
force-pushed
the
feat-faqipv6
branch
from
a3895b0
to
ea70de3
Compare
|
@outSH requesting for a re-review for the same |
Primary Changes
---------------
1. Added a new FAQ related to configure script stuck
at discovering npm registry due to IPv6 defaults
Signed-off-by: jagpreetsinghsasan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comit to be reviewed
docs(faq): added ipv6 default fix
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.